Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote translog] Add integration tests for primary term validation #8406

Merged
merged 4 commits into from
Jul 5, 2023
Merged

[Remote translog] Add integration tests for primary term validation #8406

merged 4 commits into from
Jul 5, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jul 3, 2023 •
edited
Loading

Description

Add integration test for primary term validation for remote translog enabled indexes.

Related Issues

Resolves #5636

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94
[Remote translog] Add integration tests for primary term validation
5086c7a 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 marked this pull request as ready for review July 3, 2023 13:55
@ashking94 ashking94 self-assigned this Jul 3, 2023
@ashking94 ashking94 added :test Adding or fixing a test Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0' labels Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.indices.replication.SegmentReplicationIT.testCancellation

@ashking94
Empty-Commit
2849b18 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #8406 (276098d) into main (240193a) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8406      +/-   ##
============================================
- Coverage     70.95%   70.81%   -0.14%     
+ Complexity    56994    56886     -108     
============================================
  Files          4757     4757              
  Lines        269125   269125              
  Branches      39403    39403              
============================================
- Hits         190957   190585     -372     
- Misses        62105    62471     +366     
- Partials      16063    16069       +6

see 445 files with indirect coverage changes

@ashking94
Empty-Commit
919b5fc 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

@ashking94
Fix code comments
276098d 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@sachinpkale sachinpkale merged commit 71c9302 into opensearch-project:main Jul 5, 2023
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
@ashking94 @vikasvb90
[Remote translog] Add integration tests for primary term validation (o…
8e99099 
…pensearch-project#8406)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
@ashking94 @raghuvanshraj
[Remote translog] Add integration tests for primary term validation (o…
39bd704 
…pensearch-project#8406)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
@ashking94
[Remote translog] Add integration tests for primary term validation (o…
1342c57 
…pensearch-project#8406)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
@sachinpkale sachinpkale mentioned this pull request Jul 19, 2023
Merged
@ashking94 ashking94 added the backport 2.x Backport to 2.x branch label Jul 19, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 19, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2023
@github-actions
[Remote translog] Add integration tests for primary term validation (#…
9539dab 
…8406)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 71c9302)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Jul 19, 2023
@opensearch-trigger-bot @github-actions
[Remote translog] Add integration tests for primary term validation (#…
59197bb 
…8406) (#8775)

---------


(cherry picked from commit 71c9302)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
@ashking94 @baba-devv
[Remote translog] Add integration tests for primary term validation (o…
09e3bc9 
…pensearch-project#8406)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@ashking94 @shiv0408
[Remote translog] Add integration tests for primary term validation (o…
de3b04a 
…pensearch-project#8406)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees

@ashking94 ashking94

Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Durability Issues and PRs related to the durability framework :test Adding or fixing a test v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration tests for no-op replication usecases
2 participants
@ashking94 @sachinpkale